phosek added inline comments.
================ Comment at: clang/CMakeLists.txt:215 +set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER FALSE CACHE BOOL + "Enable the experimental new pass manager by default.") ---------------- chandlerc wrote: > Does it make sense to put the word `DEFAULT` into the variable name? I don't > feel strongly either way. I was following the `ENABLE_X86_RELAX_RELOCATIONS` above which is a similar flag in terms of its effect on the driver. Would you prefer `ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER_BY_DEFAULT`? It's more descriptive but also rather long. Repository: rC Clang https://reviews.llvm.org/D44330 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits