alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed.
================ Comment at: clang-tidy/readability/UnnecessaryIntermediateVarCheck.cpp:28 + auto File = Context->getCurrentFile(); + auto Style = format::getStyle(*Context->getOptionsForFile(File).FormatStyle, + File, "none"); ---------------- I've just noticed this use of format::getStyle. The problem is that it will use the real file system, which is completely wrong for some clang-tidy use cases. I guess, we'll either have to roll this back to use a check option or create some way for checks to get the formatting style that can be implemented correctly by the client, when clang-tidy is used as a library. I suggest going back to the option and leave a FIXME to investigate the other possibility. https://reviews.llvm.org/D37014 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
