aaron.ballman added inline comments.
================
Comment at: test/clang-tidy/readability-function-size.cpp:207-212
+void variables_8() {
+ int a, b;
+ struct A {
+ A(int c, int d);
+ };
+}
----------------
I think the current behavior here is correct and the previous behavior was
incorrect. However, it brings up an interesting question about what to do here:
```
void f() {
struct S {
void bar() {
int a, b;
}
};
}
```
Does `f()` contain zero variables or two? I would contend that it has no
variables because S::bar() is a different scope than f(). But I can see a case
being made about the complexity of f() being increased by the presence of the
local class definition. Perhaps this is a different facet of the test about
number of types?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44602
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
