lichray marked an inline comment as not done. lichray added inline comments.
================ Comment at: include/support/itoa/itoa.h:29 + UINT64_C(1000), + UINT64_C(10000), + UINT64_C(100000), ---------------- EricWF wrote: > The `UINT64_C` and `UINT32_C` macros are non-standard, so I would rather not > use them in a header. > > Additionally, the compiler should correctly convert the integer type to the > array's element type, no? They are from C standard, and I included the corresponding C header. Dropping them gave me `-Wimplicitly-unsigned-literal` warning. Repository: rCXX libc++ https://reviews.llvm.org/D41458 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
