sdardis added a comment. This patch looks mostly ok, but I think there are some small issues with it.
Can you separate the new warnings/error relating to -fno-pic / -mabicalls into another patch from the change which alters the behaviour of __PIC__ / __pic__ ? The title of the patch is misleading, as you're adding warnings related to -fno-pic / -mabicalls and changing how __pic__ is defined. Repository: rC Clang https://reviews.llvm.org/D44381 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
