ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land.
================ Comment at: unittests/clangd/XRefsTests.cpp:587 - const char *HeaderContents = R"cpp([[]]int a;)cpp"; + const char *HeaderContents = R"cpp([[]]#ifndef TEST_H_ + #define TEST_H_ ---------------- hokein wrote: > ilya-biryukov wrote: > > I would go with `#pragma once` in the test code, it adds less noise. WDYT? > I thought `#pragma once` is non-standard, but the diagnostic message also > suggest this fix. Changed to it. Thanks! It's non-standard, but supported on every modern compiler, so we should be fine :-) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44294 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
