vsapsai added a comment.

In https://reviews.llvm.org/D44103#1027664, @vsk wrote:

> Is the test expected to pass with clang-902? If not, then it'd be best to use 
> "apple-clang-9" instead of "apple-clang-9.0".


That means that most likely it should be `apple-clang-8` instead of 8.0. But on 
the second thought it might be better to keep .fail.cpp and .pass.cpp more in 
sync. I think

  // XFAIL: libcpp-no-deduction-guides

is better than listing all unsupported clang versions (see r325205 
<https://reviews.llvm.org/rL325205>). I didn't test it but if it works, I 
prefer this approach.


Repository:
  rCXX libc++

https://reviews.llvm.org/D44103



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to