martong added a comment. Hi Aleksei,
I agree that there are some overlapping functionalities in the patches. As far as I see both make it possible to write tests which import from multiple contexts and I think that is the only redundant part. So, I agree, for now we could use both approaches simultaneously (i.e. merging both patches). I think the major strength of this patch is that it makes possible to access the whole API of the AST. However, with `testImportSequence` in the other patch it is not clear how could we access the internal attributes of the different AST nodes. In Ericsson, we have several fixes and other tests which depend on this Fixture and without it we can't really make them open source. Repository: rC Clang https://reviews.llvm.org/D43967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
