craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Headers/cetintrin.h:45
+static __inline__ void __DEFAULT_FN_ATTRS _inc_ssp(unsigned int __a) {
+  __builtin_ia32_incsspq(__a);
+}
----------------
GBuella wrote:
> craig.topper wrote:
> > Where is the zeroing behavior for older CPUs coming from? This 
> > implementation looks identical to _incsspq?
> Do we need some zeroing behaviour for _inc_ssp?
> I know we need it for _get_ssp.
Nevermind. I mixed up the instructions, and didn't realize that we already 
modeled rdsspq/rdsspd as taking a value as input. I assumed we would have to do 
more work. Should have looked more closely. Sorry.


https://reviews.llvm.org/D43814



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to