RKSimon added inline comments.
================ Comment at: lib/Headers/mmintrin.h:1292 /// -/// This intrinsic corresponds to the <c> VXORPS / XORPS </c> instruction. +/// This intrinsic corresponds to the <c> XOR </c> instruction. /// ---------------- craig.topper wrote: > kromanova wrote: > > craig.topper wrote: > > > PXOR? > > For which platform/compiler? > > > > I checked, for x86_64 Linux XORPS(no avx)/VXORPS (with -mavx) is generated. > > For PS4 we generate XORL. > > > > I guess, we need to write something more generic, implying that an > > appropriate platform-specific XOR instruction is generated. > Ideally to interoperate with other mmx intrinsics it should have been a PXOR > into an mmx register. But apparently our mmx support is so limited that we > aren't capable of that and instead create it in another domain and move it > over. > > I guess just indicate it as a utility function with no specific instruction. D41908 fixed MMX zero constant creation so you should be able to say "This intrinsic corresponds to the <c> PXOR </c> instruction." https://reviews.llvm.org/D41517 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
