aaron.ballman added inline comments.
================ Comment at: test/Sema/attr-print.c:12 +short arr[3] __attribute__((aligned)); + // CHECK: void foo() __attribute__((const)); ---------------- Please add a test showing that `objc_bridge_related` isn't mangled by `-ast-print`. ================ Comment at: utils/TableGen/ClangAttrEmitter.cpp:303-304 + std::string getIsOmitted() const override { + if (type == "FunctionDecl *") + return "false"; + if (type == "IdentifierInfo *") ---------------- I think you can remove this case and the `TypeSourceInfo *` as well and just rely on returning `"false"` in those cases. https://reviews.llvm.org/D43748 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits