alexfh added inline comments.
================ Comment at: clang-tidy/modernize/MakeSharedCheck.h:38 + + bool isVersionSupported(const clang::LangOptions &LangOpts) const override; }; ---------------- 1. s/clang::// 2. it's not clear which "version" is this all about. I'd suggest isLanguageSupported/isLanguageVersionSupported or something else more specific than just "version". Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43766 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits