[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

[Colden Cullen via Phabricator via cfe-commits]

colden added a comment.

In https://reviews.llvm.org/D43700#1019506, @zturner wrote:

> @rnk by "in an MSVC environment" do you mean "when -fms-compatibility is 
> present"?


It looks like other places in this file are using 
`Triple.isWindowsMSVCEnvironment()`, which I think would make sense to use for 
this too. It's implemented as:

  bool isWindowsMSVCEnvironment() const {
    return getOS() == Triple::Win32 &&
           (getEnvironment() == Triple::UnknownEnvironment ||
            getEnvironment() == Triple::MSVC);
  }

This appears to default to true from a normal Windows cmd (on my Win10 machine, 
the default triple is `x86_64-pc-windows-msvc`).


https://reviews.llvm.org/D43700



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits