george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land.
LGTM, though in general I still think we should do something on soft-failure-modes in order to aid future debugging... Is the failure mode in this case always a UB? In this case, could we emit a warning? If not from CallEvent, then from where? ================ Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:593 + // Fall back to a generic pointer cast for this-value. + const CXXMethodDecl *StaticMD = cast<CXXMethodDecl>(getDecl()); + const CXXRecordDecl *StaticClass = StaticMD->getParent(); ---------------- nit: auto? Repository: rC Clang https://reviews.llvm.org/D43659 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
