krytarowski added inline comments.
================ Comment at: lib/Driver/XRayArgs.cpp:56 + << (std::string(XRayInstrumentOption) + " only on " + "FreeBSD x86_64"); + } ---------------- I think it's better to not hardcode `x86_64` here in a message, we will need change it with new CPUs. ================ Comment at: lib/Driver/XRayArgs.cpp:60 D.Diag(diag::err_drv_clang_unsupported) << (std::string(XRayInstrumentOption) + " on non-Linux target OS"); XRayInstrument = true; ---------------- Please make this message generic - replace `non-Linux` target with a better wording. https://reviews.llvm.org/D43378 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits