Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks for looking at this. Just one thing, I was wondering whether it 
would be cleaner way if we extend 
test/CodeGenOpenCL/cl20-device-side-enqueue.cl instead of adding a new one 
here? Because this is the test that is meant to exercise all DSE codegen bits. 
Perhaps we can modify one block in that test to have the same format as here 
(i.e. using captures), since  now we test the same block there most of the 
time. However, we don't test any of kernel wrapper `*_block_invoke_kernel` 
there. Not sure why...


https://reviews.llvm.org/D43240



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to