aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

I apologize for not noticing this important detail earlier -- I think this 
check should live under `bugprone` rather than `misc`. Other than where it 
lives (and the related naming issues), I think this is looking good!



================
Comment at: test/clang-tidy/misc-throw-keyword-missing.cpp:38
+
+// Classname contains the substring "exception", in certain cases using this 
class should emit a warning.
+struct RegularException {
----------------
Classname -> Class name


https://reviews.llvm.org/D43120



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to