Szelethus marked 5 inline comments as done.
Szelethus added inline comments.
================
Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:32
+ hasType(cxxRecordDecl(
+ isSameOrDerivedFrom(matchesName("[Ee]xception|EXCEPTION")))),
+ unless(anyOf(hasAncestor(stmt(
----------------
whisperity wrote:
> `matchesName` says
>
> > Does not match typedefs of an underlying type with the given name.
>
> Does your check find the following case?
>
> ```
> typedef std::exception ERROR_BASE;
> class my_error : public ERROR_BASE {
> /* Usual yadda. */
> };
>
> int main() {
> my_error();
> }
> ```
>
It does! I've added this case to the test file.
https://reviews.llvm.org/D43120
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
