erichkeane added a comment. This seems pretty OK to me. I'd like to see @probinson s PS4 discussion bottom out, but I don't see any reason to hold this up otherwise.
We definitely should leave the format as #pragma comment(keyword, "message"), since there is significant prior art here. ================ Comment at: test/CodeGen/elf-linker-options.c:3 + +#pragma comment(lib, "alpha") + ---------------- I would like a test for Sema to validate the 'pragma ignored' warning in common cases (such as 'Linker'). Repository: rC Clang https://reviews.llvm.org/D42758 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
