erichkeane added inline comments.

================
Comment at: lib/AST/MicrosoftMangle.cpp:1717
+        Out << '8';
+        for (const char *NS : {"__swift_cc", "__Swift"})
+          mangleSourceName(NS);
----------------
When I implemented regcall, it was brought up that this was likely a bad idea, 
and to just choose a letter for mangleCallingConvention.  It is a really stable 
list as it is, and if you avoid ones in the immediate pattern, you'll be fine.


Repository:
  rC Clang

https://reviews.llvm.org/D42768



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to