compnerd added a comment.

I think that the new version is better.



================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2766
+    // Don't import the RTTI but emit it locally
+    if (CGM.getTriple().isWindowsGNUEnvironment() && IsDLLImport)
+      return false;
----------------
Can't this be simplified to ignore the `IsDLLImport`?  If it is export, it 
should be emitted, if it is import, it should emit it locally.  If it is 
static, it should also emit it locally, no?


https://reviews.llvm.org/D42641



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to