ioeric added inline comments.
================
Comment at: lib/Tooling/Tooling.cpp:404
if (CompileCommandsForFile.empty()) {
// FIXME: There are two use cases here: doing a fuzzy
// "find . -name '*.cc' |xargs tool" match, where as a user I don't care
----------------
bkramer wrote:
> This comment explains why the implementation doesn't error. Can you make sure
> the xargs use case is still working properly?
I somehow missed the big `FIXME`... thanks for the catch!
I don't think this is a very typical use case that should affect design
decision here, and I would expect `xargs` users to do something like `xargs
tool $@ || true` if they really want to ignore errors. WDYT?
Repository:
rC Clang
https://reviews.llvm.org/D42361
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
