[PATCH] D42660: [PR32482] Fix bitfield layout for -mms-bitfield and pragma pack

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/AST/RecordLayoutBuilder.cpp:1564
   unsigned MaxFieldAlignmentInBits = Context.toBits(MaxFieldAlignment);
+  unsigned RecordFieldAlign = FieldAlign;
   if (!MaxFieldAlignment.isZero() && FieldSize) {
----------------
I think naming this 'FieldAlignForRecord' would be clearer.

Other this LGTM.


Repository:
  rC Clang

https://reviews.llvm.org/D42660



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits