nikhgupt added inline comments. Herald added a subscriber: hintonda.
================ Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:395 + return XFE && !YFE; + return XFE->getName() < YFE->getName(); +} ---------------- getName could yield incorrect results if two files in the project have the same name. This might break the assert for PathDiagnostics 'total ordering' and 'uniqueness'. Maybe replacing FileEntry's getName with FullSourceLoc's getFileID could resolve this. https://reviews.llvm.org/D30691 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
