ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D42363#983769, @hokein wrote:

> Yeah, we should fix the clang bug (root cause). But I think this patch still 
> makes sense -- as we usually ignore invalid cases in clang-tidy checks.


Sure, thanks for clarifying. LGTM.
It's a bit unfortunate that the test will break when we fix an actual bug in 
clang. But it's just something to watch out for, still nice to have a test 
after the bug is fixed.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42363



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to