mclow.lists added a comment. In https://reviews.llvm.org/D42344#983265, @ng wrote:
> In https://reviews.llvm.org/D42344#983264, @mclow.lists wrote: > > > Shouldn't there be tests for `multimap` and `multiset`, too? > > > Sure; will the same tests as for map/set be alright? Actually, I think there are already tests for `multimap` and `multiset`. (which is why I deleted my comment) But the tests there are not like these, where the comparator uses only part of the key. So, yes; same tests would be OK - but you might want to adjust the data so that there are duplicate keys. https://reviews.llvm.org/D42344 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
