krasimir added inline comments.

================
Comment at: lib/Format/ContinuationIndenter.cpp:1336
+  unsigned OldSuffixSize = 2 + OldDelimiter.size();
+  std::string RawText =
+      Current.TokenText.substr(OldPrefixSize).drop_back(OldSuffixSize);
----------------
bkramer wrote:
> Can this be a StringRef? Can RawText outlive the Current token?
Nice catch! The reformatting code creates a virtual source code environment 
which expects a null-terminated string. Added a comment why this is necessary.


Repository:
  rC Clang

https://reviews.llvm.org/D42187



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to