rnk added inline comments.

================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3867
+    // subsequent catches in the same try statement to catch such a rethrow.
+    // See C++ DR 388.
+    if (!CanBindToTemporary && MaybeTypeMatch) {
----------------
Based on our conversation, this fix feels a bit heroic. I think it would be 
better to find a way to put the const-ness in the LSDA and let new versions of 
the EH runtime deal with this.


Repository:
  rC Clang

https://reviews.llvm.org/D42092



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D42092: i... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D420... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D420... Reid Kleckner via Phabricator via cfe-commits
    • [PATCH] D420... John McCall via Phabricator via cfe-commits

Reply via email to