ilya-biryukov added inline comments.
================
Comment at: clangd/index/SymbolCollector.cpp:75
+ // Skip nameless declarations.
+ if (ND->getDeclName().isEmpty())
+ return true;
----------------
What are those declarations exactly?
================
Comment at: unittests/clangd/SymbolCollectorTests.cpp:174
+ enum class Color2 {
+ Yellow
+ };
----------------
I'd say we should drop `enum` constants inside stongly-typed enums (i.e. `enum
class`).
They can't be found inside namespace by code completion, therefore being
similar to static method in that regard. (And we don't include static methods
now, right?)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42074
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
