ckennelly marked 2 inline comments as done.
ckennelly added a comment.
In https://reviews.llvm.org/D41746#973941, @EricWF wrote:
> This LGTM minus nits.
>
> Is there a LWG issue or paper that specifies this change? or is it just a
> general bug fix?
This is just a general bug fix.
================
Comment at: include/memory:2007
+#if !defined(_LIBCPP_HAS_NO_ALIGNED_ALLOCATION)
+ if (alignof(_Tp) > __STDCPP_DEFAULT_NEW_ALIGNMENT__)
+ {
----------------
EricWF wrote:
> Please use the `alignment_of` trait; since that's always available within the
> library, but different spellings of the `alignof` keyword aren't.
I also guarded for __STDCPP_DEFAULT_NEW_ALIGNMENT__
Repository:
rCXX libc++
https://reviews.llvm.org/D41746
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
