aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/PCH/include-stream-type.cpp:7
+// RUN: cp %S/Inputs/pragma-once2.h %t-dir
+// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %t-dir/pragma-once2-pch.h
+// RUN: llvm-bcanalyzer -dump %t | FileCheck %s
----------------
modocache wrote:
> aprantl wrote:
> > You may need to pass an explicit -fmodule-format=raw for this to work on 
> > macOS. Did you test there?
> Yup, I tested this on my macOS host machine and it seems to pass. Should add 
> that option anyway, just in case?
Let's add it, just to be explicit and document the intent here.


Repository:
  rC Clang

https://reviews.llvm.org/D41980



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to