ilya-biryukov added inline comments.
================ Comment at: clangd/ClangdLSPServer.h:40 + bool BuildDynamicSymbolIndex, + std::unique_ptr<SymbolIndex> StaticIdx); ---------------- sammccall wrote: > is there a reason ClangdServer should own this? I can imagine this > complicating life for embedders. (vs a raw pointer) +1, we had a design where `ClangdServer` owns everything before and having a raw reference turned out to be much more flexible! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41668 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
