Ping. Is this direction OK? Should a put the time to update the existing tests to account for dso_local?
I do volunteer to implement the rest of ELF, COFF and MachO once this is in. Cheers, Rafael Rafael Avila de Espindola <rafael.espind...@gmail.com> writes: > Reid Kleckner via Phabricator <revi...@reviews.llvm.org> writes: > >> rnk added inline comments. >> >> >> ================ >> Comment at: lib/CodeGen/CodeGenModule.cpp:690-692 >> + // Only handle ELF for now. >> + if (!CGM.getTriple().isOSBinFormatELF()) >> + return false; >> ---------------- >> Handling COFF here is probably trivial. Everything is dso_local unless it's >> dllimport. Does that matter, or is dso_local intended to be an ELF-specific >> annotation? > > The dso_local attribute is for all file formats. This patch is ELF only > in the interest of being incremental. > > In addition of what this patch shows there will be a lot of test updates > because of dso_local showing up, so splitting up the patches is probably > a good thing. > > Cheers, > Rafael _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
