aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Aside from some minor nits, LGTM. Thanks! ================ Comment at: include/clang/Basic/Attr.td:281 list<string> CXXABIs; + // Specifies Object Formats for which the target applies, based off the + // ObjectFormatType enumeration in Triple.h ---------------- Extra space after "Formats" ================ Comment at: utils/TableGen/ClangAttrEmitter.cpp:2665 + // If one or more architectures is specified, check those. Arches are handled + // differently because GenerateTargetRequiresments needs to combine the list + // with ParseKind. ---------------- Typo: GenerateTargetRequiresments Repository: rC Clang https://reviews.llvm.org/D41303 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
