ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed.
LGTM modulo the comment. Should I land this for you? ================ Comment at: include/clang/Frontend/PrecompiledPreamble.h:247 + /// Can be used to store references to various CompilerInstance fields + /// (e.g. SourceManager) that may be interesting to the consumers of other callbacks. ---------------- Please add that the following information to the comment: ``` /// Called before FrontendAction::BeginSourceFile . /// Can be used .... ``` Repository: rC Clang https://reviews.llvm.org/D41365 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits