ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land.
lgtm! This is amazing! ================ Comment at: unittests/clangd/Annotations.h:12 +// +// Annotations Example(R"cpp( +// int complete() { x.pri^ } // ^ indicates a point ---------------- Does this support overlapping annotations like (named) points in (named) ranges? ================ Comment at: unittests/clangd/Annotations.h:45 + // Crashes if there isn't exactly one. + Position point(llvm::StringRef Name = "") const; + // Returns the position of all points marked by ^ (or $name^) in the text. ---------------- Is this the position in the stripped code or the original text? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41432 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits