NoQ added a comment.




================
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:522
+    symVal = peekCXXNewAllocatorValue(State);
+  State = popCXXNewAllocatorValue(State);
+
----------------
a.sidorin wrote:
> Should this be under 'if' as well?
Whooooooooops!! Thanks!

Apparently, `ImmutableList::getTail()` doesn't crash when the list is empty. 
And i thought we're catching this sort of bugs.

Added the relevant assertion into `popCXXNewAllocatorValue()`.


https://reviews.llvm.org/D40560



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to