ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM modulo a few comments.
AFAIK, @Nebiroth does not have a commit access, so I'll land this with minor
tweaks to unblock the other patch.
================
Comment at: include/clang/Frontend/PrecompiledPreamble.h:261
/// used instead, but having only this method allows a simpler API.
virtual void HandleMacroDefined(const Token &MacroNameTok,
const MacroDirective *MD);
----------------
This method can now be removed as its use-case is now covered by
`createPPCallbacks`
================
Comment at: lib/Frontend/PrecompiledPreamble.cpp:716
const MacroDirective *MD) {}
+std::unique_ptr<PPCallbacks> PreambleCallbacks::createPPCallbacks() {return
nullptr;}
----------------
Please `clang-format` the code when submitting patches.
Repository:
rC Clang
https://reviews.llvm.org/D39375
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
