sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
I don't see `FileSymbols.{h,cpp}` being deleted, but maybe I'm bad at reading diffs. ================ Comment at: clangd/index/FileIndex.h:8 +// +//===----------------------------------------------------------------------===// + ---------------- Add a file-comment about what this is and how it's going to be used? At the moment almost all the comments are on FileSymbols and implementation-focused, while FileIndex is the interesting class. ================ Comment at: clangd/index/FileIndex.h:57 + + bool fuzzyFind(Context &Ctx, const FuzzyFindRequest &Req, + std::function<void(const Symbol &)> Callback) const; ---------------- override Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41276 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits