sammccall added a comment.
Oops, forgot one important question!
BTW, phabricator seems to have misaligned all my previous comments (you updated
the diff before I submitted them I guess). Let me know if any of them don't
make sense now!
================
Comment at: clangd/Context.h:63
+/// used as parents for some other Contexts.
+class Context {
+public:
----------------
I think we should strongly consider calling the class Ctx over Context. It's
going to appear in many function signatures, and I'm not sure the extra
characters buy us anything considering the abbreviation is pretty unambiguous,
and the full version isn't very explicit.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
