samparker added a comment. Thanks for looking into this!
================ Comment at: include/clang/Basic/BuiltinsARM.def:39 BUILTIN(__builtin_arm_qsub, "iii", "nc") +BUILTIN(__builtin_arm_qdbl, "ii", "nc") BUILTIN(__builtin_arm_ssat, "iiUi", "nc") ---------------- Do we now need a codegen tests for this one? ================ Comment at: test/Sema/builtins-arm.c:161 + r = __builtin_arm_smulwt(-1, -2); + r = __builtin_arm_smulwt(-1.0f, -2); +} ---------------- Interesting that this doesn't give an error? ================ Comment at: test/Sema/builtins-arm.c:236 + y = __builtin_arm_uxtab16(c, d); + y = __builtin_arm_uxtab16(-1, -2); + y = __builtin_arm_uxtb16(d); ---------------- Can / should we warn the user when using signed arguments? Looks like I missed the unsigned qualifiers in the original patch. https://reviews.llvm.org/D40888 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
