================
@@ -153,23 +153,27 @@ class SetVector {
}
/// Insert a new element into the SetVector.
- /// \returns true if the element was inserted into the SetVector.
- bool insert(const value_type &X) {
+ /// \returns a pair, whose first member is the iterator pointed to the
+ /// element, and the second member indicates if the element was inserted.
+ std::pair<iterator, bool> insert(const value_type &X) {
----------------
eugeneepshteyn wrote:
Some callers are still unconverted:
- `clang/lib/CIR/CodeGen/CIRGenModule.cpp:2591` (`if
(!importedModules.insert(mod))`) does not compile with ClangIR enabled. It is
the compile error in this PR's Linux CI.
- `clang/lib/Frontend/Rewrite/RewriteModernObjC.cpp:5175,5182` and
`clang/lib/Frontend/Rewrite/RewriteObjC.cpp:4345,4353` (`... &&
BlockByCopyDecls.insert(VD)`) are compiled only with
`-DCLANG_ENABLE_OBJC_REWRITER=ON`, which premerge CI does not set, so CI will
not report them.
Every out-of-tree `if (!S.insert(X))` stops compiling as well, so this is not
NFC: it needs a release note.
https://github.com/llvm/llvm-project/pull/232372
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
