anemet added a subscriber: davide.
anemet added a comment.

@modocache, @davide, are you guys sure this feature is working?  The test does 
not actually check whether hotness is included in the remarks and when I run it 
manually they are missing.  In https://reviews.llvm.org/D40678, I am filtering 
out remarks with no hotness when any threshold is set all the remarks are 
filtered out in this new test.

So either the test is incorrect or somehow with sample-based profiling we don't 
get hotness info.

Any ideas?  I am inclined to just remove this test for now and file a bug to 
fix this in order to unblock https://reviews.llvm.org/D40678.


https://reviews.llvm.org/D34082



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to