https://github.com/necto approved this pull request.
> I created a regression test mostly for the sake of curiosity (and it is > indeed crashing without the fix), but I think this is a good example of a > regression test that doesn't deserve to be in the repository. (Even the space > occupied by its filename in ls output outweighs its usefulness.) > What do you think about this? I thin it absolutely deserves a regression test. Having this bug in the codebase means the test coverage of this logic was not sufficient. I agree with Balazs that you should use `split-file` to make the test occupy less space in `ls` output and make it self-contained. https://github.com/llvm/llvm-project/pull/237447 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
