klimek added a comment. In https://reviews.llvm.org/D37813#941987, @Typz wrote:
> Definitely that would be much more expressive. But this approach is also > incomplete: in case of namespace (and possibly others?), we also need to > perform the reverse operation, e.g. to "generate" a macro call for rewriting > the closing comment. > > On top of this, I think that is really not trivial, I would prefer to move > forward with these "simpler" patch, and change the whole macro configurations > part in later commits... Looking at the tests, I see what you mean, but I'd actually vote to not add non-namespace closing comments, or at least make closing comments configurable in a different way - it seems very much unrelated? https://reviews.llvm.org/D37813 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
