JonasToth added inline comments.
================ Comment at: test/clang-tidy/nolintnextline.cpp:14 + +// NOLINTNEXTLINE(not-closed-bracket-is-treated-as-skip-all +class C2 { C2(int i); }; ---------------- xgsa wrote: > JonasToth wrote: > > xgsa wrote: > > > JonasToth wrote: > > > > missing `)` > > > No, it's intentionally: it's a test for case when `)` is missing > > It was early, i didn't read properly. Sorry for that. > > > > A testcase for where all parens are missing would be nice, too. I assume > > that everything will be ignored, is that correct? > There is such test case (for class "B") or did you mean something else? No i mean an errornous NOLINT. Like `// NOLINT some_check, othercheck, blaa`. One might expect it to work, but the missing parens would inhibit that expected behaviour. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits