Maoyao233 wrote: Pushed fixup commit `ab9d6709` addressing the review points:
- test: add `REQUIRES: x86-registered-target` (the test triples to an X86 target) and rename to `clang/test/Modules/reduced-bmi-msvc-dtor-operator-delete.cpp` to follow the existing `reduced-bmi-*` naming; - test: emit reduced module interfaces for the two module units and only LLVM IR for the consumer, and add a `FileCheck` check that the emitted deleting destructor calls the resolved `operator delete` (pre-fix this still aborts in assertions builds / segfaults in release builds); - description: fix the issue reference (`#231589`), typos, and the duplicated Itanium-ABI paragraph, and mention the measured cost (`std.pcm` byte-identical on libstdc++/libc++; `b.pcm` +256 B on the reproducer). The branch still needs CI approval for the new commit. https://github.com/llvm/llvm-project/pull/235673 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
