https://github.com/shafik commented:

Please fill out your summary, a good summary should be short as possible, 
concise and answer: What, Why and How. What did you change, it does not have to 
exhaustive but should provide enough details so a reviewer(s) knows what to 
expect. Why did you make the change, understanding the motivation for the 
change can often clarify choices you made that without having a rationale could 
be surprising. Finally, how did you make the changes, did you use a different 
algorithm or data structure, did you add extra checks or assertions, what 
design choices/tradeoffs did you make etc



https://github.com/llvm/llvm-project/pull/235341
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to