llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Jan Korous (jkorous-apple) <details> <summary>Changes</summary> A transformation reads the whole-program analysis result through Transformation's WPASuite member. Name the member for what it holds. AnalysisRes rather than AnalysisResult, which would hide the clang::ssaf::AnalysisResult class in every transformation. Assisted-by: Claude --- Full diff: https://github.com/llvm/llvm-project/pull/235183.diff 3 Files Affected: - (modified) clang/include/clang/ScalableStaticAnalysis/SourceTransformation/Transformation.h (+3-3) - (modified) clang/lib/ScalableStaticAnalysis/SourceTransformation/Transformations/CppBoundedBuffers.cpp (+2-2) - (modified) clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp (+1-1) ``````````diff diff --git a/clang/include/clang/ScalableStaticAnalysis/SourceTransformation/Transformation.h b/clang/include/clang/ScalableStaticAnalysis/SourceTransformation/Transformation.h index 5416facab0dd4b..ad953b43a9736a 100644 --- a/clang/include/clang/ScalableStaticAnalysis/SourceTransformation/Transformation.h +++ b/clang/include/clang/ScalableStaticAnalysis/SourceTransformation/Transformation.h @@ -25,12 +25,12 @@ class SSAFOptions; class Transformation : public clang::ASTConsumer { public: - Transformation(const WPASuite &Suite, const SSAFOptions &Opts, + Transformation(const WPASuite &AnalysisRes, const SSAFOptions &Opts, SourceEditEmitter &Edits, TransformationReportEmitter &Report) - : Suite(Suite), Opts(Opts), Edits(Edits), Report(Report) {} + : AnalysisRes(AnalysisRes), Opts(Opts), Edits(Edits), Report(Report) {} protected: - const WPASuite &Suite; + const WPASuite &AnalysisRes; const SSAFOptions &Opts; SourceEditEmitter &Edits; TransformationReportEmitter &Report; diff --git a/clang/lib/ScalableStaticAnalysis/SourceTransformation/Transformations/CppBoundedBuffers.cpp b/clang/lib/ScalableStaticAnalysis/SourceTransformation/Transformations/CppBoundedBuffers.cpp index c119ee2f01c5ea..a055f29ba14df5 100644 --- a/clang/lib/ScalableStaticAnalysis/SourceTransformation/Transformations/CppBoundedBuffers.cpp +++ b/clang/lib/ScalableStaticAnalysis/SourceTransformation/Transformations/CppBoundedBuffers.cpp @@ -593,13 +593,13 @@ classifyDeclType(QualType T, const llvm::SmallSet<unsigned, 4> &ReachableLevels, } void CppBoundedBuffers::HandleTranslationUnit(ASTContext &Ctx) { - auto Reachable = Suite.get<UnsafeBufferReachableAnalysisResult>(); + auto Reachable = AnalysisRes.get<UnsafeBufferReachableAnalysisResult>(); if (!Reachable) { llvm::consumeError(Reachable.takeError()); return; } - ReachabilityMap Reach(Suite, Reachable->Reachables); + ReachabilityMap Reach(AnalysisRes, Reachable->Reachables); NestedBuildNamespace TUNamespace = NestedBuildNamespace::makeCompilationUnit(Opts.CompilationUnitId); NestedBuildNamespace LUNamespace = diff --git a/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp b/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp index 2909cdfc5821ba..5aed7ee49ba90d 100644 --- a/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp +++ b/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp @@ -42,7 +42,7 @@ class TestTransformation final : public Transformation { using Transformation::Transformation; void HandleTranslationUnit(ASTContext &Ctx) override { - bool SuiteIsNonEmpty = Suite.getIdTable().count() > 0; + bool SuiteIsNonEmpty = AnalysisRes.getIdTable().count() > 0; Visitor V{*this, Ctx, SuiteIsNonEmpty}; V.TraverseDecl(Ctx.getTranslationUnitDecl()); } `````````` </details> https://github.com/llvm/llvm-project/pull/235183 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
