https://github.com/jsji created https://github.com/llvm/llvm-project/pull/235194
CIR libraries include mlir/IR/BuiltinTypeInterfaces.h, which needs the generated BuiltinTypeInterfaces.h.inc, but did not depend on MLIRBuiltinTypeInterfacesIncGen. This caused intermittent build failures when objects were compiled before the header was generated. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> >From c6e28c0b6e8cd2df0d3d77ed57625e73b258298c Mon Sep 17 00:00:00 2001 From: Jinsong Ji <[email protected]> Date: Fri, 23 Oct 2026 19:43:08 -0700 Subject: [PATCH] [CIR][CMake] Add missing BuiltinTypeInterfaces tablegen dependency CIR libraries include mlir/IR/BuiltinTypeInterfaces.h, which needs the generated BuiltinTypeInterfaces.h.inc, but did not depend on MLIRBuiltinTypeInterfacesIncGen. This caused intermittent build failures when objects were compiled before the header was generated. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> --- clang/lib/CIR/CodeGen/CMakeLists.txt | 1 + clang/lib/CIR/Dialect/IR/CMakeLists.txt | 1 + clang/lib/CIR/Dialect/OpenACC/CMakeLists.txt | 1 + clang/lib/CIR/Dialect/Transforms/CMakeLists.txt | 1 + clang/lib/CIR/Dialect/Transforms/TargetLowering/CMakeLists.txt | 1 + clang/lib/CIR/FrontendAction/CMakeLists.txt | 1 + clang/lib/CIR/Interfaces/CMakeLists.txt | 1 + clang/lib/CIR/Lowering/CMakeLists.txt | 1 + clang/lib/CIR/Lowering/DirectToLLVM/CMakeLists.txt | 1 + 9 files changed, 9 insertions(+) diff --git a/clang/lib/CIR/CodeGen/CMakeLists.txt b/clang/lib/CIR/CodeGen/CMakeLists.txt index c201540b962d9..d8faa943d2883 100644 --- a/clang/lib/CIR/CodeGen/CMakeLists.txt +++ b/clang/lib/CIR/CodeGen/CMakeLists.txt @@ -69,6 +69,7 @@ add_clang_library(clangCIR MLIRCIR MLIRCIROpInterfacesIncGen MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen LINK_LIBS diff --git a/clang/lib/CIR/Dialect/IR/CMakeLists.txt b/clang/lib/CIR/Dialect/IR/CMakeLists.txt index 34345d765c67c..baf42de05651e 100644 --- a/clang/lib/CIR/Dialect/IR/CMakeLists.txt +++ b/clang/lib/CIR/Dialect/IR/CMakeLists.txt @@ -15,6 +15,7 @@ add_clang_library(MLIRCIR MLIRCIROpInterfacesIncGen MLIRCIRLoopOpInterfaceIncGen MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen LINK_COMPONENTS diff --git a/clang/lib/CIR/Dialect/OpenACC/CMakeLists.txt b/clang/lib/CIR/Dialect/OpenACC/CMakeLists.txt index d15624e1f21a2..1a149f76da1e8 100644 --- a/clang/lib/CIR/Dialect/OpenACC/CMakeLists.txt +++ b/clang/lib/CIR/Dialect/OpenACC/CMakeLists.txt @@ -6,6 +6,7 @@ add_clang_library(CIROpenACCSupport MLIRCIRTypeConstraintsIncGen MLIRArithOpsIncGen MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen MLIRCallInterfacesIncGen diff --git a/clang/lib/CIR/Dialect/Transforms/CMakeLists.txt b/clang/lib/CIR/Dialect/Transforms/CMakeLists.txt index 968382bf9f516..d5ea3fc968494 100644 --- a/clang/lib/CIR/Dialect/Transforms/CMakeLists.txt +++ b/clang/lib/CIR/Dialect/Transforms/CMakeLists.txt @@ -22,6 +22,7 @@ add_clang_library(MLIRCIRTransforms DEPENDS MLIRCIRPassIncGen MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen LINK_COMPONENTS diff --git a/clang/lib/CIR/Dialect/Transforms/TargetLowering/CMakeLists.txt b/clang/lib/CIR/Dialect/Transforms/TargetLowering/CMakeLists.txt index 7bad234541d35..5df261e7dd8b0 100644 --- a/clang/lib/CIR/Dialect/Transforms/TargetLowering/CMakeLists.txt +++ b/clang/lib/CIR/Dialect/Transforms/TargetLowering/CMakeLists.txt @@ -12,6 +12,7 @@ add_clang_library(MLIRCIRTargetLowering DEPENDS clangBasic MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen LINK_COMPONENTS diff --git a/clang/lib/CIR/FrontendAction/CMakeLists.txt b/clang/lib/CIR/FrontendAction/CMakeLists.txt index f83e5b04b9ada..a1facd60c80f7 100644 --- a/clang/lib/CIR/FrontendAction/CMakeLists.txt +++ b/clang/lib/CIR/FrontendAction/CMakeLists.txt @@ -14,6 +14,7 @@ add_clang_library(clangCIRFrontendAction MLIRCIROpsIncGen MLIRCIROpInterfacesIncGen MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen MLIRBuiltinOpsIncGen diff --git a/clang/lib/CIR/Interfaces/CMakeLists.txt b/clang/lib/CIR/Interfaces/CMakeLists.txt index 960dd0dcca5f4..cc4889223a036 100644 --- a/clang/lib/CIR/Interfaces/CMakeLists.txt +++ b/clang/lib/CIR/Interfaces/CMakeLists.txt @@ -14,6 +14,7 @@ add_clang_library(MLIRCIRInterfaces MLIRCIRLoopOpInterfaceIncGen MLIRCIROpInterfacesIncGen MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen MLIRCIROpsIncGen MLIRCIRTypeConstraintsIncGen diff --git a/clang/lib/CIR/Lowering/CMakeLists.txt b/clang/lib/CIR/Lowering/CMakeLists.txt index 93ca5436d96f9..54193a877e82a 100644 --- a/clang/lib/CIR/Lowering/CMakeLists.txt +++ b/clang/lib/CIR/Lowering/CMakeLists.txt @@ -9,6 +9,7 @@ add_clang_library(clangCIRLoweringCommon DEPENDS MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen LINK_LIBS diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/CMakeLists.txt b/clang/lib/CIR/Lowering/DirectToLLVM/CMakeLists.txt index ff68221ad59df..325f3b35d7dc5 100644 --- a/clang/lib/CIR/Lowering/DirectToLLVM/CMakeLists.txt +++ b/clang/lib/CIR/Lowering/DirectToLLVM/CMakeLists.txt @@ -14,6 +14,7 @@ add_clang_library(clangCIRLoweringDirectToLLVM MLIRCIREnumsGen MLIRCIROpsIncGen MLIRBuiltinLocationAttributesIncGen + MLIRBuiltinTypeInterfacesIncGen MLIRBytecodeOpInterfaceIncGen MLIRCIROpInterfacesIncGen _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
